Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): type cast correctly for IE 11 bug breaking URL Unificati… #30464

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jasonaden
Copy link
Contributor

commented May 14, 2019

…on when comparing objects

PR #30393 corrected behavior where Object.keys sometimes returns an undefined value. However, the types didn't reflect this in the code. That fix actually missed one value that could return undefined. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects

PR #30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

@jasonaden jasonaden requested a review from angular/fw-router as a code owner May 14, 2019

@googlebot googlebot added the cla: yes label May 14, 2019

@jasonaden

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@jasonaden jasonaden closed this in 53f3564 May 15, 2019

jasonaden added a commit that referenced this pull request May 15, 2019

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects (#30464)

PR #30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

PR Close #30464

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects (angular#30464)

PR angular#30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

PR Close angular#30464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.