Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add ability to watch for AngularJS URL updates through … #30466

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@jasonaden
Copy link
Contributor

commented May 14, 2019

onUrlChange hook

The LocationShim (replacement for $location was added to centralize dealing with the browser URL. Additionally, an onUrlChange method was added to Angular's Location service. This PR adds a corresponding method to the LocationShim so updates from AngularJS can be tracked in Angular.

@googlebot googlebot added the cla: yes label May 14, 2019

@jasonaden jasonaden force-pushed the jasonaden:location_shim_url_change branch 2 times, most recently from ace0c10 to 9a9ebf6 May 15, 2019

@jasonaden jasonaden requested a review from IgorMinar May 15, 2019

@jasonaden jasonaden marked this pull request as ready for review May 15, 2019

@jasonaden jasonaden requested review from angular/fw-public-api as code owners May 15, 2019

@jasonaden

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@jasonaden jasonaden force-pushed the jasonaden:location_shim_url_change branch from 9a9ebf6 to ac6b427 May 15, 2019

@jasonaden jasonaden changed the title feat(router): add ability to watch for AngularJS URL updates through … feat(common): add ability to watch for AngularJS URL updates through … May 15, 2019

@gkalpak
Copy link
Member

left a comment

Commit message typo (missing closing ): (replacement for `$location` --> (replacement for `$location`)

Show resolved Hide resolved packages/common/upgrade/src/location_shim.ts Outdated
Show resolved Hide resolved packages/common/upgrade/src/location_shim.ts Outdated
Show resolved Hide resolved packages/common/upgrade/test/upgrade.spec.ts
Show resolved Hide resolved packages/common/upgrade/test/upgrade.spec.ts Outdated
Show resolved Hide resolved packages/common/upgrade/src/location_shim.ts Outdated
feat(common): add ability to watch for AngularJS URL updates through …
…`onUrlChange` hook

The LocationShim (replacement for `$location`) was added to centralize dealing with the browser URL. Additionally, an `onUrlChange` method was added to Angular's Location service. This PR adds a corresponding method to the LocationShim so updates from AngularJS can be tracked in Angular.

@jasonaden jasonaden force-pushed the jasonaden:location_shim_url_change branch from 292c626 to 606bbdc May 15, 2019

@jasonaden jasonaden requested a review from IgorMinar May 15, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 15, 2019

@IgorMinar
Copy link
Member

left a comment

lgtm. thanks for making the changes.

jasonaden added a commit that referenced this pull request May 16, 2019

feat(common): add ability to watch for AngularJS URL updates through …
…`onUrlChange` hook (#30466)

The LocationShim (replacement for `$location`) was added to centralize dealing with the browser URL. Additionally, an `onUrlChange` method was added to Angular's Location service. This PR adds a corresponding method to the LocationShim so updates from AngularJS can be tracked in Angular.

PR Close #30466

@jasonaden jasonaden closed this in 1aff524 May 16, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

feat(common): add ability to watch for AngularJS URL updates through …
…`onUrlChange` hook (angular#30466)

The LocationShim (replacement for `$location`) was added to centralize dealing with the browser URL. Additionally, an `onUrlChange` method was added to Angular's Location service. This PR adds a corresponding method to the LocationShim so updates from AngularJS can be tracked in Angular.

PR Close angular#30466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.