Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove deprecated annotation for TestBed.get #30514

Closed
wants to merge 1 commit into from

Conversation

@cexbrayat
Copy link
Contributor

commented May 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29905 and FW-1336

What is the new behavior?

PR #29290 introduced a new TestBed.get signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the @deprecated annotation in favor of a plain text warning until we properly fix it.

Does this PR introduce a breaking change?

  • Yes
  • No

@cexbrayat cexbrayat requested a review from angular/fw-core as a code owner May 16, 2019

@googlebot googlebot added the cla: yes label May 16, 2019

@cexbrayat cexbrayat force-pushed the cexbrayat:fix/29905-test-bed-get branch from 832f78f to 4249ec7 May 16, 2019

@cexbrayat cexbrayat requested a review from angular/fw-public-api as a code owner May 16, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 16, 2019

@kara
Copy link
Contributor

left a comment

Minor nit

Show resolved Hide resolved packages/core/testing/src/test_bed.ts

@cexbrayat cexbrayat force-pushed the cexbrayat:fix/29905-test-bed-get branch from 4249ec7 to 9b11f49 May 17, 2019

@cexbrayat cexbrayat requested a review from kara May 17, 2019

@cexbrayat cexbrayat removed their assignment May 17, 2019

@kara

kara approved these changes May 17, 2019

Copy link
Contributor

left a comment

LGTM, though we should still get a public API review from @IgorMinar

@IgorMinar
Copy link
Member

left a comment

I also suggest that you rename the commit message to "fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get overload"

Show resolved Hide resolved packages/core/testing/src/test_bed.ts
fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get…
… overload

PR #29290 introduced a new `TestBed.get` signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it.

Refs #29905
Fixes FW-1336

@cexbrayat cexbrayat force-pushed the cexbrayat:fix/29905-test-bed-get branch from 9b11f49 to 7f50ab1 May 18, 2019

@cexbrayat cexbrayat requested a review from IgorMinar May 18, 2019

@cexbrayat

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2019

@IgorMinar I updated the doc to mention the TSLint issue according to your feedback and changed the commit message.

@ngbot

This comment has been minimized.

Copy link

commented May 20, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing
    failure status "ci/angular: size" is failing
    pending status "codefresh-angular" is pending
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar

This comment has been minimized.

Copy link
Member

commented May 20, 2019

merge-assistance: ci is flaky

@jasonaden jasonaden closed this in f6bf892 May 21, 2019

jasonaden added a commit that referenced this pull request May 21, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get…
… overload (#30514)

PR #29290 introduced a new `TestBed.get` signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it.

Refs #29905
Fixes FW-1336

PR Close #30514

cexbrayat added a commit to cexbrayat/angular that referenced this pull request May 29, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
…ic.get overload

Followup to angular#30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

AndrewKushnir added a commit that referenced this pull request Jun 14, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714

AndrewKushnir added a commit that referenced this pull request Jun 14, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.