Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): ng test should run specific ts_web_test_suite #30526

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@kyliau
Copy link
Member

commented May 16, 2019

PR closes #30191

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-bazel as a code owner May 16, 2019

@googlebot googlebot added the cla: yes label May 16, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 16, 2019

@gregmagolan gregmagolan self-requested a review May 16, 2019

@gregmagolan
Copy link
Contributor

left a comment

I would just add in the commit message why the change is needed and that it assumes that the BUILD files are the ones generated by ng new.

The downside of this is that if you leave BUILD files on disk and add more tests than ng test will no longer run all tests which may be unexpected. Maybe Alex's suggestion to mark rollup_bundle as "manual" would be better?

@mgechev

This comment has been minimized.

Copy link
Member

commented May 19, 2019

This LGTM but I'll let @alexeagle & @gregmagolan give the final approval.

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

I agree with @gregmagolan that users may get confused over the behavior when they start to customize the build, but they'll have to understand which targets to run when they do that. This would be a good fix for 8

@alexeagle alexeagle modified the milestones: needsTriage, version 8 May 20, 2019

@jasonaden jasonaden closed this in e688e02 May 20, 2019

jasonaden added a commit that referenced this pull request May 20, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.