Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8/static queries patch #30641

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
4 participants
@alxhub
Copy link
Contributor

commented May 23, 2019

Patch version of #30639, including Kara's cherry-picked fixes.

@kara

kara approved these changes May 23, 2019

Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

merge-assistance: global approval

@alxhub alxhub force-pushed the alxhub:v8/static-queries-patch branch from 712d158 to fbf247d May 23, 2019

@alxhub alxhub force-pushed the alxhub:v8/static-queries-patch branch from fbf247d to f9fe21c May 23, 2019

@alxhub alxhub force-pushed the alxhub:v8/static-queries-patch branch from f9fe21c to db618de May 23, 2019

@alxhub alxhub requested a review from angular/fw-testing as a code owner May 23, 2019

fix(core): require 'static' flag on queries in typings
This commit makes the static flag on @ViewChild and @ContentChild required.

BREAKING CHANGE:

In Angular version 8, it's required that all @ViewChild and @ContentChild
queries have a 'static' flag specifying whether the query is 'static' or
'dynamic'. The compiler previously sorted queries automatically, but in
8.0 developers are required to explicitly specify which behavior is wanted.
This is a temporary requirement as part of a migration; see
https://angular.io/guide/static-query-migration for more details.

@ViewChildren and @ContentChildren queries are always dynamic, and so are
unaffected.

@alxhub alxhub force-pushed the alxhub:v8/static-queries-patch branch from db618de to 8230ad7 May 23, 2019

@alxhub alxhub requested a review from angular/docs-infra as a code owner May 23, 2019

@kara

kara approved these changes May 23, 2019

Copy link
Contributor

left a comment

LGTM

@alxhub alxhub added the aio: preview label May 23, 2019

@mary-poppins

This comment has been minimized.

jasonaden added a commit that referenced this pull request May 23, 2019

jasonaden added a commit that referenced this pull request May 23, 2019

jasonaden added a commit that referenced this pull request May 23, 2019

fix(core): require 'static' flag on queries in typings (#30641)
This commit makes the static flag on @ViewChild and @ContentChild required.

BREAKING CHANGE:

In Angular version 8, it's required that all @ViewChild and @ContentChild
queries have a 'static' flag specifying whether the query is 'static' or
'dynamic'. The compiler previously sorted queries automatically, but in
8.0 developers are required to explicitly specify which behavior is wanted.
This is a temporary requirement as part of a migration; see
https://angular.io/guide/static-query-migration for more details.

@ViewChildren and @ContentChildren queries are always dynamic, and so are
unaffected.

PR Close #30641

@alxhub alxhub closed this May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.