Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0 remaining deprecations #30642

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
6 participants
@alxhub
Copy link
Contributor

commented May 23, 2019

Two deprecations for 8.0.

@alxhub

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@kara

kara approved these changes May 23, 2019

Copy link
Contributor

left a comment

LGTM

@IgorMinar IgorMinar changed the title V8/deprecations v8.0 remaining deprecations May 23, 2019

@IgorMinar
Copy link
Member

left a comment

can you please list the deprecated symbols in the deprecation's guide index table https://github.com/angular/angular/blob/master/aio/content/guide/deprecations.md#index

thanks!

@alxhub alxhub force-pushed the alxhub:v8/deprecations branch from 8699ddb to 7fecd09 May 23, 2019

@alxhub

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@IgorMinar done!

@Splaktar
Copy link
Member

left a comment

Are we sure that the platform-webworker* API will be removed in version 10? do we need to specify that in the multiple comments? or should that just be reflected in the deprecation guide?

Show resolved Hide resolved aio/content/guide/deprecations.md Outdated
Show resolved Hide resolved aio/content/guide/deprecations.md Outdated
Show resolved Hide resolved aio/content/guide/deprecations.md Outdated
Show resolved Hide resolved aio/content/guide/deprecations.md Outdated

alxhub added some commits May 23, 2019

feat(core): deprecate integration with the Web Tracing Framework (WTF)
DEPRECATION:

Angular previously has supported an integration with the Web Tracing
Framework (WTF) for performance testing of Angular applications. This
integration has not been maintained and likely does not work for the
majority of Angular applications today. As a result, we are deprecating
the integration in Angular version 8.

This deprecation covers the following public APIs:
* `WtfScopeFn`
* `wtfCreateScope`
* `wtfStartTimeRange`
* `wtfEndTimeRange`
* `wtfLeave`

FW-1338 #resolve
feat(platform-webworker): deprecate platform-webworker
DEPRECATION:

platform-webworker has been around since the initial release of Angular
version 2. It began as an experiment to leverage Angular's rendering
architecture and try something different: to run an entire web application
in a web worker.

We've learned a lot from this experiment, and have come to the conclusion
that pushing entire applications to run in a web worker is not a recipe for
success for most applications. This is due to a number of unresolved issues,
including:

* Poor or non-existent support for web worker APIs in web crawlers/indexers.
* Poor support in build and bundling tooling.

As a result, as of Angular version 8, we are deprecating the
`platform-webworker` APIs in Angular. This consists of both NPM packages,
`@angular/platform-webworker` and `@angular/platform-webworker-dynamic`.

Going forward, we will focus our efforts related to web workers around their
primary use case of offloading CPU-intensive but not critical work.

FW-1339 #resolve

@alxhub alxhub force-pushed the alxhub:v8/deprecations branch from 7fecd09 to 9fe8df8 May 23, 2019

@alxhub alxhub added the aio: preview label May 23, 2019

@mary-poppins

This comment has been minimized.

@jasonaden jasonaden closed this in f310a59 May 23, 2019

jasonaden added a commit that referenced this pull request May 23, 2019

feat(platform-webworker): deprecate platform-webworker (#30642)
DEPRECATION:

platform-webworker has been around since the initial release of Angular
version 2. It began as an experiment to leverage Angular's rendering
architecture and try something different: to run an entire web application
in a web worker.

We've learned a lot from this experiment, and have come to the conclusion
that pushing entire applications to run in a web worker is not a recipe for
success for most applications. This is due to a number of unresolved issues,
including:

* Poor or non-existent support for web worker APIs in web crawlers/indexers.
* Poor support in build and bundling tooling.

As a result, as of Angular version 8, we are deprecating the
`platform-webworker` APIs in Angular. This consists of both NPM packages,
`@angular/platform-webworker` and `@angular/platform-webworker-dynamic`.

Going forward, we will focus our efforts related to web workers around their
primary use case of offloading CPU-intensive but not critical work.

FW-1339 #resolve

PR Close #30642

jasonaden added a commit that referenced this pull request May 23, 2019

feat(core): deprecate integration with the Web Tracing Framework (WTF) (
#30642)

DEPRECATION:

Angular previously has supported an integration with the Web Tracing
Framework (WTF) for performance testing of Angular applications. This
integration has not been maintained and likely does not work for the
majority of Angular applications today. As a result, we are deprecating
the integration in Angular version 8.

This deprecation covers the following public APIs:
* `WtfScopeFn`
* `wtfCreateScope`
* `wtfStartTimeRange`
* `wtfEndTimeRange`
* `wtfLeave`

FW-1338 #resolve

PR Close #30642

jasonaden added a commit that referenced this pull request May 23, 2019

feat(platform-webworker): deprecate platform-webworker (#30642)
DEPRECATION:

platform-webworker has been around since the initial release of Angular
version 2. It began as an experiment to leverage Angular's rendering
architecture and try something different: to run an entire web application
in a web worker.

We've learned a lot from this experiment, and have come to the conclusion
that pushing entire applications to run in a web worker is not a recipe for
success for most applications. This is due to a number of unresolved issues,
including:

* Poor or non-existent support for web worker APIs in web crawlers/indexers.
* Poor support in build and bundling tooling.

As a result, as of Angular version 8, we are deprecating the
`platform-webworker` APIs in Angular. This consists of both NPM packages,
`@angular/platform-webworker` and `@angular/platform-webworker-dynamic`.

Going forward, we will focus our efforts related to web workers around their
primary use case of offloading CPU-intensive but not critical work.

FW-1339 #resolve

PR Close #30642
@Splaktar

This comment has been minimized.

Copy link
Member

commented May 23, 2019

I got pulled away for a bit after the AIO preview was posted, so I didn't get a chance to look at it. We now have duplicated anchors and platform-webworker deprecation sections.

The one from PR #30598:
is right above https://next.angular.io/guide/deprecations#platform-webworker-angular-applications

The one from this PR:
https://next.angular.io/guide/deprecations#platform-webworker-angular-applications

The platform-webworker id is defined twice:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.