Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat… #30714

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@cexbrayat
Copy link
Contributor

commented May 29, 2019

…ic.get overload

Followup to #30514 which did the same for TestBed, but TestBedStatic was necessary too.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29905

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
…ic.get overload

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

@cexbrayat cexbrayat requested review from angular/fw-core as code owners May 29, 2019

@googlebot googlebot added the cla: yes label May 29, 2019

@matsko matsko added the comp: core label May 30, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 30, 2019

@kara

kara approved these changes Jun 13, 2019

Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Merge assistance: global approval

AndrewKushnir added a commit that referenced this pull request Jun 14, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714

@cexbrayat cexbrayat deleted the cexbrayat:fix/29905-test-bed-get branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.