Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): exclude components schematics from build #30825

Closed
wants to merge 1 commit into from

Conversation

@jelbourn
Copy link
Member

commented Jun 3, 2019

See angular/components#16189

Without this, bazel attempts to build schematics templates as srcs

@jelbourn jelbourn requested a review from alexeagle Jun 3, 2019

@jelbourn jelbourn requested a review from angular/tools-bazel as a code owner Jun 3, 2019

@googlebot googlebot added the cla: yes label Jun 3, 2019

@jelbourn jelbourn requested a review from devversion Jun 3, 2019

@@ -21,6 +21,8 @@
"node_modules/@angular/compiler-cli/**",
"node_modules/@angular/**/testing/**",
"node_modules/@angular/common/upgrade*",
"node_modules/@angular/router/upgrade*"
"node_modules/@angular/router/upgrade*",

This comment has been minimized.

Copy link
@alan-agius4

alan-agius4 Jun 3, 2019

Contributor

This LGTM.

Though probably we should do something more generic to catch all

 "node_modules/@angular/*/schematics/**",
@ngbot

This comment has been minimized.

Copy link

commented Jun 3, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_aio" is failing
    pending missing required labels: PR target: *
    pending status "ci-codefresh-bazel" is pending
    pending status "ci/circleci: integration_test" is pending
    pending missing required status "ci/circleci: publish_snapshot"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kyliau

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

fix(bazel): exclude components schematics from build
See angular/components#16189

Without this, bazel attempts to build schematics templates as srcs

@jelbourn jelbourn force-pushed the bazel-schem-excl branch from 6a74978 to 95ad7f1 Jun 5, 2019

@jelbourn jelbourn requested a review from angular/fw-integration as a code owner Jun 5, 2019

@jelbourn

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

The aio test seems unrelated to this change

@ngbot

This comment has been minimized.

Copy link

commented Jun 5, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_aio" is failing
    pending missing required labels: PR target: *
    pending status "ci-codefresh-bazel" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kyliau

kyliau approved these changes Jun 5, 2019

@@ -21,6 +21,8 @@
"node_modules/@angular/compiler-cli/**",
"node_modules/@angular/**/testing/**",
"node_modules/@angular/common/upgrade*",
"node_modules/@angular/router/upgrade*"
"node_modules/@angular/router/upgrade*",
"node_modules/@angular/cdk/schematics*",

This comment has been minimized.

Copy link
@Maximebpro

Maximebpro Jun 6, 2019

You may want to also exclude "node_modules/@angular/cdk/typings/schematics*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.