Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): do not modify tsconfig.json #30877

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

commented Jun 5, 2019

Before this change, user's tsconfig.json is cloned and some options
controlled by Bazel are removed otherwise Bazel would complain about:

WARNING: your tsconfig.json file specifies options which are overridden by Bazel:
 - compilerOptions.target and compilerOptions.module are controlled by downstream dependencies, such as ts_devserver
 - compilerOptions.typeRoots is always set to the @types subdirectory of the node_modules attribute
 - compilerOptions.rootDir and compilerOptions.baseUrl are always the workspace root directory

Since the warning has been removed in rules_typescript/8d8d398, there's no
need to clone and backup tsconfig.json

PR Closes #30104

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Jun 5, 2019

@googlebot googlebot added the cla: yes label Jun 5, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jun 5, 2019

@googlebot googlebot added the cla: yes label Jun 5, 2019

@kyliau kyliau force-pushed the kyliau:tsconfig_backup branch from 9c36dc7 to 2043443 Jun 5, 2019

@kyliau kyliau requested a review from angular/fw-integration as a code owner Jun 5, 2019

@kyliau

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

@alexeagle This is now good to go, @bazel/typescript 0.31.1 has been released.

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

fix(bazel): do not modify tsconfig.json
Before this change, user's tsconfig.json is cloned and some options
controlled by Bazel are removed otherwise Bazel would complain about:

```
WARNING: your tsconfig.json file specifies options which are overridden by Bazel:
 - compilerOptions.target and compilerOptions.module are controlled by downstream dependencies, such as ts_devserver
 - compilerOptions.typeRoots is always set to the @types subdirectory of the node_modules attribute
 - compilerOptions.rootDir and compilerOptions.baseUrl are always the workspace root directory
```

Since the warning has been removed in rules_typescript/8d8d398, there's no
need to clone and backup tsconfig.json

@kyliau kyliau force-pushed the kyliau:tsconfig_backup branch from 2043443 to 46d7969 Jun 11, 2019

@kyliau kyliau requested a review from IgorMinar as a code owner Jun 11, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@kyliau merging this PR to patch branch failed due to some conflicts. I've changed the label to "master-only" and merged it to master. Could you please create a separate PR and target patch branch? Thank you.

kyliau added a commit to kyliau/angular that referenced this pull request Jun 11, 2019

@kyliau kyliau referenced this pull request Jun 11, 2019

Closed

fix(bazel): do not modify tsconfig.json #30984

2 of 14 tasks complete

AndrewKushnir added a commit that referenced this pull request Jun 11, 2019

fix(bazel): do not modify tsconfig.json (#30984)
This is a patch PR for #30877

PR Close #30984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.