Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): HttpParams fromObject accepts ReadonlyArray<str… #31072

Open
wants to merge 1 commit into
base: master
from

Conversation

@MansourFall
Copy link

commented Jun 15, 2019

…ing>

Fixes #28452

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28452

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@MansourFall MansourFall requested a review from angular/fw-http as a code owner Jun 15, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jun 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jun 15, 2019

@MansourFall

This comment has been minimized.

Copy link
Author

commented Jun 15, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Jun 15, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 15, 2019

@MansourFall MansourFall force-pushed the MansourFall:fix/httpParams-fromObject-fix-28452 branch from 38ae83b to ba8159c Jun 15, 2019

@cexbrayat

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

@MansourFall Can you update the commit message with feat(common): HttpParams fromObject accepts ReadonlyArray<string> please?

@cexbrayat cexbrayat changed the title feat@angular/common): HttpParams fromObject accepts ReadonlyArray<str… feat(common): HttpParams fromObject accepts ReadonlyArray<str… Jun 15, 2019

@MansourFall MansourFall force-pushed the MansourFall:fix/httpParams-fromObject-fix-28452 branch from ba8159c to 0138e5c Jun 15, 2019

@MansourFall

This comment has been minimized.

Copy link
Author

commented Jun 15, 2019

@cexbrayat update done! thanks!

@alxhub

alxhub approved these changes Jun 18, 2019

@kara kara added the comp: common label Jun 19, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jun 19, 2019

@cexbrayat

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@MansourFall Would you mind rebasing the PR to resolve the conflict? Basically keeping the new signature, but with the updated comment:

/** Object map of the HTTP parameters. Mutually exclusive with `fromString`. */
fromObject?: {[param: string]: string | ReadonlyArray<string>};

To do so:

git fetch upstream
git rebase upstream/master
# resolve the conflict
git add packages/common/http/src/params.ts
git rebase --continue
# check if everything is OK
git show
# all good? ready to push!
git push --force

When that's done we should be able to merge it!

@MansourFall MansourFall force-pushed the MansourFall:fix/httpParams-fromObject-fix-28452 branch from 0138e5c to d1a47c9 Jul 30, 2019

@MansourFall

This comment has been minimized.

Copy link
Author

commented Jul 30, 2019

@cexbrayat thank you for the instructions, just made the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.