Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(service-worker): registration failed on Safari #31140
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Service worker failed to register on Safari.
What is the new behavior?
Registered service worker.
Does this PR introduce a breaking change?
It's a regression of Angular v8, it was ok in v7.
3 times, most recently
Jun 19, 2019
I tried to rerun the CI as the errors that showed up seem no longer present on the lastest master. If that doesn't help @H--o-l can you please rebase your PR on top of the most recent master and forcepush to this branch?
gkalpak left a comment
gkalpak left a comment •
For future reference:
@H--o-l, can you please update the commit message to not contain
Sorry for the confusion, @H--o-l. I approved it, but added the
I marked the PR for merging. Thx, again, for working on this