Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): fix Elements not making a new ParseSourceSpan #31190

Closed

Conversation

Projects
None yet
3 participants
@ayazhafiz
Copy link
Member

commented Jun 21, 2019

Change the Element constructor in r3_ast to create a new ParseSourceSpan when regenerating it rather than extending an object, which does not contain the overloaded toString().

Same as #31153. Retrying here because tests on the other PR failed, I think because it was a patch on the master repo.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Parsing a template that has an element with adjacent start and end tags creates an object to represent the element ParseSourceSpan rather than a new instance of a ParseSourceSpan, which does not make the overloaded ParseSourceSpan.toString accessible.

What is the new behavior?

Create a new ParseSourceSpan instance.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(compiler): fix Elements not making a new ParseSourceSpan
Change the Element constructor in r3_ast to create a new ParseSourceSpan when regenerating it rather than extending an object, which does not contain the overloaded toString().

@ayazhafiz ayazhafiz requested a review from angular/fw-compiler as a code owner Jun 21, 2019

@googlebot googlebot added the cla: yes label Jun 21, 2019

@ayazhafiz ayazhafiz requested a review from alxhub Jun 21, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jun 21, 2019

@alxhub

alxhub approved these changes Jun 21, 2019

@kara kara closed this in 7035f22 Jun 21, 2019

@ayazhafiz ayazhafiz deleted the ayazhafiz:fix/element-parsespan-patch branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.