fix(router): require explicit base href #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btford
added
type: bug/fix
comp: router
action: review
btford
force-pushed
the
fix-facade-explicit-base-href
branch
from
15e3a47
to
241b842
Compare
|
didn't we find that this caused a lot (a few?) of problems for SVG in 1.x? /cc @jeffbcross |
|
For those cases you can provide a binding to It might be better for |
vsavkin
added
pr_state: LGTM
action: merge
btford
force-pushed
the
fix-facade-explicit-base-href
branch
2 times, most recently
from
1c4314f
to
f3b3325
Compare
Previously, calls to getBaseHref used document.baseURI, which defaults to the current path in the absence of a base element in the document. This leads to surprising behavior. With this change, getBaseHref returns null when a base element is not present in the document.
btford
force-pushed
the
fix-facade-explicit-base-href
branch
from
f3b3325
to
011fab3
Compare
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calls to
getBaseHrefuseddocument.baseURI, which defaults to the current path in the absence of a base element in the document. This leads to surprising behavior.With this change,
getBaseHrefreturnsnullwhen a base element is not present in the document, andLocationthrows a more prescriptive error message.Closes #3096