Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): update ng new schema to match the current ng new schema o… #31234

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@alan-agius4
Copy link
Contributor

commented Jun 24, 2019

fix(bazel): update ng new schema to match the current ng new schema of @schematics/angular
The schema used in ng-new bazel, includes several outdated options. With this update we match the current version of @schematics/angular: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/ng-new/schema.json

Relates to #31233

fix(bazel): remove unsupported Css pre-processors from ng new
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

@alan-agius4 alan-agius4 requested a review from angular/tools-bazel as a code owner Jun 24, 2019

@googlebot googlebot added the cla: yes label Jun 24, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:update-schema-ng-new branch from 4c9bb10 to 1e4b260 Jun 24, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jun 24, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:update-schema-ng-new branch from 1e4b260 to 08180d2 Jun 24, 2019

alan-agius4 added some commits Jun 24, 2019

fix(bazel): update ng new schema to match the current ng new schema o…
…f @schematics/angular

The schema used in ng-new bazel, includes several outdated options. With this update we match the current version of @schematics/angular: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/ng-new/schema.json

Relates to #31233
fix(bazel): remove unsupported Css pre-processors from ng new
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

@alan-agius4 alan-agius4 force-pushed the alan-agius4:update-schema-ng-new branch from 08180d2 to 196de6a Jun 24, 2019

@alan-agius4 alan-agius4 requested a review from kyliau Jun 24, 2019

@kyliau

kyliau approved these changes Jun 24, 2019

@kara kara closed this in 805fc86 Jun 24, 2019

kara added a commit that referenced this pull request Jun 24, 2019

fix(bazel): remove unsupported Css pre-processors from ng new (#31234)
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

PR Close #31234

kara added a commit that referenced this pull request Jun 24, 2019

fix(bazel): update ng new schema to match the current ng new schema o…
…f @schematics/angular (#31234)

The schema used in ng-new bazel, includes several outdated options. With this update we match the current version of @schematics/angular: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/ng-new/schema.json

Relates to #31233

PR Close #31234

kara added a commit that referenced this pull request Jun 24, 2019

fix(bazel): remove unsupported Css pre-processors from ng new (#31234)
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

PR Close #31234

@alan-agius4 alan-agius4 deleted the alan-agius4:update-schema-ng-new branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.