Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): allow passing a custom bazel compiler host to ngc compile #31341

Closed
wants to merge 1 commit into from

Conversation

@ayazhafiz
Copy link
Member

commented Jun 28, 2019

Enable users to pass a custom Bazel CompilerHost to use for an Angular
compilation. This supports users who must override the TypeScript
compiler host.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Users cannot pass a specialized compiler host to ngc_wrapped#compile

Issue Number: N/A

What is the new behavior?

Users can pass a specialized compiler host to ngc_wrapped#compile

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

feat(bazel): allow passing a custom bazel compiler host to ngc compile
Enable users to pass a custom Bazel CompilerHost to use for an Angular
compilation. This supports users who must override the TypeScript
compiler host.

@ayazhafiz ayazhafiz requested review from alexeagle and kyliau Jun 28, 2019

@ayazhafiz ayazhafiz requested a review from angular/tools-bazel as a code owner Jun 28, 2019

@ayazhafiz ayazhafiz self-assigned this Jun 28, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jun 28, 2019

@googlebot googlebot added the cla: yes label Jun 28, 2019

@kyliau

kyliau approved these changes Jun 28, 2019

Copy link
Member

left a comment

This is for the Angular indexer inside Google. The indexer does not have access to file system, and must perform fs operations through a proxy. Allowing the compile function to accept a bazelHost provides a way to talk to the proxy.

@ayazhafiz ayazhafiz removed the request for review from alexeagle Jun 28, 2019

@alxhub alxhub closed this in a29dc96 Jun 28, 2019

ayazhafiz added a commit to ayazhafiz/angular that referenced this pull request Jul 2, 2019

feat(bazel): allow passing and rewriting an old bazel host
Updates the decision made in angular#31341; this is for the Angular indexer
inside Google. The indexer currently passes (and ngc-wrapped#compile
accepts) a bazel host to use, but because many methods are overwritten
specially for Angular compilation a better approach is to pass an old
bazel compiler host and siphon methods needed off of it before creating
a new host. This enables that.

alxhub added a commit that referenced this pull request Jul 2, 2019

feat(bazel): allow passing and rewriting an old bazel host (#31381)
Updates the decision made in #31341; this is for the Angular indexer
inside Google. The indexer currently passes (and ngc-wrapped#compile
accepts) a bazel host to use, but because many methods are overwritten
specially for Angular compilation a better approach is to pass an old
bazel compiler host and siphon methods needed off of it before creating
a new host. This enables that.

PR Close #31381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.