Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): allow passing and rewriting an old bazel host #31381

Closed
wants to merge 2 commits into from

Conversation

@ayazhafiz
Copy link
Member

commented Jul 2, 2019

Updates the decision made in #31341; this is for the Angular indexer
inside Google. The indexer currently passes (and ngc-wrapped#compile
accepts) a bazel host to use, but because many methods are overwritten
specially for Angular compilation a better approach is to pass an old
bazel compiler host and siphon methods needed off of it before creating
a new host. This enables the later approach.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The indexer currently passes (and ngc-wrapped#compile accepts) a bazel host to use.

What is the new behavior?

ngc-wrapped#compile accepts an old bazel compiler host and siphons methods off of it before creating a new host.

Does this PR introduce a breaking change?

  • Yes
  • No

This breaks the Angular indexer inside Google. Is it highly unlikely that anyone is using this API. Migration plan is to change the bazelHost property passed to compile to oldBazelHost.

Other information

feat(bazel): allow passing and rewriting an old bazel host
Updates the decision made in #31341; this is for the Angular indexer
inside Google. The indexer currently passes (and ngc-wrapped#compile
accepts) a bazel host to use, but because many methods are overwritten
specially for Angular compilation a better approach is to pass an old
bazel compiler host and siphon methods needed off of it before creating
a new host. This enables that.

@ayazhafiz ayazhafiz requested a review from angular/tools-bazel as a code owner Jul 2, 2019

@ayazhafiz ayazhafiz self-assigned this Jul 2, 2019

@googlebot googlebot added the cla: yes label Jul 2, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jul 2, 2019

@ayazhafiz ayazhafiz requested a review from kyliau Jul 2, 2019

@kyliau

kyliau approved these changes Jul 2, 2019

@kyliau

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@alxhub alxhub closed this in 11a208f Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.