Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): revert location of xi18n outputs to bazel-genfiles #31410

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@alexeagle
Copy link
Contributor

commented Jul 3, 2019

This is needed in g3 where the translation system is sensitive to the full path of the output.

@alexeagle alexeagle requested a review from gregmagolan Jul 3, 2019

@alexeagle alexeagle requested a review from angular/fw-dev-infra as a code owner Jul 3, 2019

@googlebot googlebot added the cla: yes label Jul 3, 2019

@kara

kara approved these changes Jul 3, 2019

Copy link
Contributor

left a comment

LGTM

@alexeagle alexeagle force-pushed the alexeagle:revert_xi18n branch from 9cd341a to a5f1c8d Jul 3, 2019

@alexeagle alexeagle requested a review from angular/fw-integration as a code owner Jul 3, 2019

@alexeagle alexeagle force-pushed the alexeagle:revert_xi18n branch from a5f1c8d to ec6b3f7 Jul 3, 2019

@gregmagolan
Copy link
Contributor

left a comment

LGTM

@alexeagle alexeagle force-pushed the alexeagle:revert_xi18n branch from ec6b3f7 to f7998f5 Jul 3, 2019

@alexeagle alexeagle requested a review from angular/tools-bazel as a code owner Jul 3, 2019

@alexeagle alexeagle force-pushed the alexeagle:revert_xi18n branch from f7998f5 to 55071f3 Jul 3, 2019

fix(bazel): revert location of xi18n outputs to bazel-genfiles
This is needed in g3 where the translation system is sensitive to the full path of the output.
For Bazel users, we don't want this because it would force them to
disable a Bazel option that prevents using the deprecated ctx.new_file
API

@alexeagle alexeagle force-pushed the alexeagle:revert_xi18n branch from 55071f3 to e720377 Jul 3, 2019

@alxhub alxhub closed this in 1d3e227 Jul 3, 2019

@alexeagle alexeagle deleted the alexeagle:revert_xi18n branch Jul 3, 2019

akanshgulati added a commit to akanshgulati/angular that referenced this pull request Jul 5, 2019

fix: revert location of xi18n outputs to bazel-genfiles (angular#31410)
This is needed in g3 where the translation system is sensitive to the full path of the output.
For Bazel users, we don't want this because it would force them to
disable a Bazel option that prevents using the deprecated ctx.new_file
API

PR Close angular#31410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.