Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): pass custom bazel compiler host rather than rewriting one #31496

Closed
wants to merge 1 commit into from

Conversation

@ayazhafiz
Copy link
Contributor

commented Jul 10, 2019

Switch back to passing a custom bazel host instead of rewriting one that
is passed to compile now that the Angular indexer is stable.

Revert "feat(bazel): allow passing and rewriting an old bazel host"

This reverts commit 0a4c1c8.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Rewrites an old bazel host.

Issue Number: N/A

What is the new behavior?

User has to define their own bazel host

Does this PR introduce a breaking change?

  • Yes
  • No

Should only impact the Angular indexer inside Google. This change is has not been documented and announced publicly.

fix(bazel): pass custom bazel compiler host rather than rewriting one
Switch back to passing a custom bazel host instead of rewriting one that
is passed to `compile` now that the Angular indexer is stable.

Revert "feat(bazel): allow passing and rewriting an old bazel host"

This reverts commit 0a4c1c8.

@ayazhafiz ayazhafiz requested a review from angular/tools-bazel as a code owner Jul 10, 2019

@googlebot googlebot added the cla: yes label Jul 10, 2019

@ayazhafiz ayazhafiz requested a review from kyliau Jul 10, 2019

@ayazhafiz ayazhafiz self-assigned this Jul 10, 2019

@ngbot ngbot bot modified the milestone: needsTriage Jul 10, 2019

@kyliau

kyliau approved these changes Jul 10, 2019

@matsko matsko closed this in 0c61a35 Jul 12, 2019

@ayazhafiz ayazhafiz deleted the ayazhafiz:feature/old-bazel-host branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.