Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): compile targets used for indexing by Kythe with Ivy #31786

Closed
wants to merge 1 commit into from

Conversation

@ayazhafiz
Copy link
Contributor

commented Jul 22, 2019

This switches all Angular targets to be built with the same Angular compiler architecture (c.n. Ivy) that the Angular indexer uses. This eliminates issues with cross-references to transitive dependencies not being generated because of the way such dependencies are loaded by the legacy compiler arch.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

feat(bazel): compile targets used for indexing by Kythe with Ivy
This switches all Angular targets to be built with the same Angular compiler architecture (c.n. Ivy) that the Angular indexer uses. This eliminates issues with cross-references to transitive dependencies not being generated because of the way such dependencies are loaded by the legacy compiler arch.

@ayazhafiz ayazhafiz requested a review from angular/fw-dev-infra as a code owner Jul 22, 2019

@ayazhafiz ayazhafiz self-assigned this Jul 22, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jul 22, 2019

@googlebot googlebot added the cla: yes label Jul 22, 2019

@ayazhafiz ayazhafiz requested a review from alexeagle Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.