View processing create update split #32020
This PR splits view processing into a set of 2 dedicated functions:
Such split allows us to greatly reduce a number of checks (memory access and computation) for both create and update mode.
This PR has all the commits as they were written to ease review. The essential part (new
With all the changes in this PR we get massive perf improvement (~2s -> ~1s in a dedicated benchmark) for view traversal and great reduction in number of concepts / code duplication.
3 times, most recently
Aug 6, 2019
kara left a comment
Love these changes! Happy that we were able to remove so much code duplication during the perf cleanup.
Most of the comments are nits/questions except the one about failing G3 tests
PR action: cleanup
PR action: presubmit
PR action: review
Aug 12, 2019
Aug 13, 2019
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.