Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(common): update $locationShim to notify onChange listeners before… #32037
… emitting AngularJS events
The $locationShim has onChange listeners to allow for synchronization logic between
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Listeners to the $locationShim onChange are notified after the $locationChangeSuccess or $locationChangeStart events.
Issue Number: N/A
What is the new behavior?
Listeners to the $locationShim onChange are notified immediately before the $locationChangeSuccess or $locationChangeStart events.
Does this PR introduce a breaking change?
If someone is already using this method and depending on the existing ordering of events then technically this could be breaking. But the contract for the onChange method doesn't make any guarentees about the ordering of these events, it just says that the listeners are notified.
See b/138246666 for more details on the Google internal bug causing this change.
Global TAP presubmit passed: https://test.corp.google.com/ui#id=OCL:262973801:BASE:262952437:1565659296935:d49307b2
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.