Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): don't read global state when interpolated values don't change #32093

Conversation

@pkozlowski-opensource
Copy link
Member

commented Aug 10, 2019

This PR refactors code so the global state (getSelectedIndex()) is not accessed until it is needed (interpolated value actually changed). Most of the CD loops will see most of the interpolations unchanged so it is important to guard global state access.

@kara

kara approved these changes Aug 12, 2019

Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.