Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): avoid first template pass checks during view creation #32120

Conversation

@pkozlowski-opensource
Copy link
Member

commented Aug 13, 2019

This PR removes the firstTemplatePass checks from the embedded view creation by observing that we can create a host TViewNode while creating an embedded TView. It also removes some code as a "side effect".

There are further optimisations (both code size and runtime perf) possible - we could delay creation of an embedded TView until a TemplateRef is injected. But this move will have to wait till we get rid of JS block instructions (will be much easier to do then).

@googlebot googlebot added the cla: yes label Aug 13, 2019

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:ivy_embedded_view_creation branch from 0515b1c to 9020881 Aug 13, 2019

@ngbot ngbot bot modified the milestone: needsTriage Aug 13, 2019

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Aug 13, 2019

@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Aug 13, 2019

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:ivy_embedded_view_creation branch from 9020881 to a19fd0e Aug 14, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@kara
kara approved these changes Aug 15, 2019
Copy link
Contributor

left a comment

LGTM

@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Sep 15, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.