Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): ensure binding ordering doesn't mess up when a `NO_CHANGE` value is encountered #32143

Closed
wants to merge 1 commit into from

Conversation

@matsko
Copy link
Member

commented Aug 14, 2019

Prior to this fix if a NO_CHANGE value was assigned to a binding, or
an interpolation value rendererd a NO_CHANGE value, then the presence
of that value would cause the internal counter index values to not
increment properly. This patch ensures that this doesn't happen and
that the counter/bitmask values update accordingly.

@googlebot googlebot added the cla: yes label Aug 14, 2019

@ngbot ngbot bot added this to the needsTriage milestone Aug 14, 2019

expect(div.style.opacity).toEqual('0.5');

comp.w = '500px';
comp.h = NO_CHANGE;

This comment has been minimized.

Copy link
@pkozlowski-opensource

pkozlowski-opensource Aug 15, 2019

Member

This is odd... I don't think we want to export the NO_CHANGE as an external / public API so users shouldn't be able to write this code. Or is this test a proxy for some other scenario where you end up with NO_CHANGE?

This comment has been minimized.

Copy link
@matsko

matsko Aug 15, 2019

Author Member

This PR isn't ready yet which is why it's in draft mode. This was a pre-emptive effort to see if all tests pass through CI.

@matsko matsko force-pushed the matsko:test_styling_no_change branch 6 times, most recently from ed26c9b to cf0073e Aug 15, 2019

@matsko matsko marked this pull request as ready for review Aug 16, 2019

@matsko matsko requested review from angular/fw-core as code owners Aug 16, 2019

@matsko matsko force-pushed the matsko:test_styling_no_change branch from cf0073e to 6d71be2 Aug 20, 2019

@matsko matsko force-pushed the matsko:test_styling_no_change branch 6 times, most recently from c11d75b to c51abdf Aug 30, 2019

@matsko

This comment has been minimized.

@matsko matsko force-pushed the matsko:test_styling_no_change branch from c51abdf to 679a6ee Aug 30, 2019

@matsko matsko force-pushed the matsko:test_styling_no_change branch 4 times, most recently from fd13d18 to dc9297c Sep 3, 2019

fix(ivy): ensure binding ordering doesn't mess up when a `NO_CHANGE` …
…value is encountered

Prior to this fix if a `NO_CHANGE` value was assigned to a binding, or
an interpolation value rendererd a `NO_CHANGE` value, then the presence
of that value would cause the internal counter index values to not
increment properly. This patch ensures that this doesn't happen and
that the counter/bitmask values update accordingly.

@matsko matsko force-pushed the matsko:test_styling_no_change branch from dc9297c to 3df4b0d Sep 4, 2019

@angular angular deleted a comment from alfaproject Sep 4, 2019

@mhevery mhevery closed this in 7cc4225 Sep 4, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(ivy): ensure binding ordering doesn't mess up when a `NO_CHANGE` …
…value is encountered (angular#32143)

Prior to this fix if a `NO_CHANGE` value was assigned to a binding, or
an interpolation value rendererd a `NO_CHANGE` value, then the presence
of that value would cause the internal counter index values to not
increment properly. This patch ensures that this doesn't happen and
that the counter/bitmask values update accordingly.

PR Close angular#32143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.