Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): ngTemplateOutlet error when switching between null and template value #32160

Closed

Conversation

@crisbeto
Copy link
Member

commented Aug 16, 2019

Fixes an error that is thrown by ngTemplateOutlet under Ivy when switching from a template to null and back to a template. The error is thrown because the reference to the previous ViewRef is never cleared and the directive tries to detach a view that has already been detached.

Fixes #32060.

fix(ivy): ngTemplateOutlet error when switching between null and temp…
…late value

Fixes an error that is thrown by `ngTemplateOutlet` under Ivy when switching from a template to null and back to a template. The error is thrown because the reference to the previous ViewRef is never cleared and the directive tries to detach a view that has already been detached.

Fixes #32060.

@crisbeto crisbeto requested a review from angular/fw-core as a code owner Aug 16, 2019

@ngbot ngbot bot modified the milestone: needsTriage Aug 16, 2019

@googlebot googlebot added the cla: yes label Aug 16, 2019

@kara
kara approved these changes Aug 17, 2019
Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

ngdevelop-tech added a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
fix(ivy): ngTemplateOutlet error when switching between null and temp…
…late value (angular#32160)

Fixes an error that is thrown by `ngTemplateOutlet` under Ivy when switching from a template to null and back to a template. The error is thrown because the reference to the previous ViewRef is never cleared and the directive tries to detach a view that has already been detached.

Fixes angular#32060.

PR Close angular#32160
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(ivy): ngTemplateOutlet error when switching between null and temp…
…late value (angular#32160)

Fixes an error that is thrown by `ngTemplateOutlet` under Ivy when switching from a template to null and back to a template. The error is thrown because the reference to the previous ViewRef is never cleared and the directive tries to detach a view that has already been detached.

Fixes angular#32060.

PR Close angular#32160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.