Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): update to the latest `@microsoft/api-extractor` #32185

Closed
wants to merge 2 commits into from

Conversation

@alan-agius4
Copy link
Contributor

commented Aug 19, 2019

Update usages of @microsoft/api-extractor to the latest version

@alan-agius4 alan-agius4 requested review from angular/fw-dev-infra as code owners Aug 19, 2019

@googlebot googlebot added the cla: yes label Aug 19, 2019

alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Aug 19, 2019
fix(bazel): pin `@microsoft/api-extractor`
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening upstream.

API wil be updated on master angular#32185
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Aug 19, 2019
fix(bazel): pin `@microsoft/api-extractor`
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master angular#32185

@ngbot ngbot bot added this to the needsTriage milestone Aug 19, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:api-extractor-test branch from c75c637 to 33ebfb5 Aug 19, 2019

alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Aug 19, 2019
fix(bazel): pin `@microsoft/api-extractor`
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master angular#32185
@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Will need to investigate why certain declarations are being wrapped with double quotes examples;

declare class "ɵNgNoValidate" {
}
export { "ɵNgNoValidate" as ɵNgNoValidate }
export { "ɵNgNoValidate" as ɵangular_packages_forms_forms_z }
@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

AndrewKushnir added a commit that referenced this pull request Aug 19, 2019
fix(bazel): pin `@microsoft/api-extractor` (#32187)
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master #32185

PR Close #32187
AndrewKushnir added a commit that referenced this pull request Aug 19, 2019
fix(bazel): pin `@microsoft/api-extractor` (#32187)
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master #32185

PR Close #32187
ngdevelop-tech added a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
fix(bazel): pin `@microsoft/api-extractor` (angular#32187)
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master angular#32185

PR Close angular#32187
@alexeagle
Copy link
Contributor

left a comment

I assume the new version produces identical output, and that's why this PR doesn't include any test or golden file changes?

packages/bazel/src/api-extractor/index.ts Outdated Show resolved Hide resolved
@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@alexeagle, the output is indeed the same, at least for the integration tests.

Though it breaks the output of the actual angular packages which we don’t have golden files for. Linked issues above.

@alan-agius4 alan-agius4 force-pushed the alan-agius4:api-extractor-test branch from 33ebfb5 to 3909763 Aug 30, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:api-extractor-test branch from 3909763 to a2d2ef2 Aug 30, 2019

@matsko matsko closed this in 350ea47 Aug 30, 2019

@alan-agius4 alan-agius4 deleted the alan-agius4:api-extractor-test branch Aug 30, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(bazel): pin `@microsoft/api-extractor` (angular#32187)
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master angular#32185

PR Close angular#32187
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.