Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): handle expressions in i18n attributes properly #32309

Closed

Conversation

@AndrewKushnir
Copy link
Contributor

commented Aug 24, 2019

Prior to this commit, complex expressions (that require additional statements to be generated) were handled incorrectly in case they were used in attributes annotated with i18n flags. The problem was caused by the fact that extra statements were not appended to the temporary vars block, so they were missing in generated code. This commit updated the logic to use the convertPropertyBinding function, which contains the necessary code to append extra statements. The convertExpressionBinding function was removed as it duplicates the convertPropertyBinding one (for the most part) and is no longer used.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
@AndrewKushnir AndrewKushnir requested review from angular/fw-compiler as code owners Aug 24, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 24, 2019
@googlebot googlebot added the cla: yes label Aug 24, 2019
@AndrewKushnir AndrewKushnir force-pushed the AndrewKushnir:i18n_complex_expr_in_attrs branch 2 times, most recently from f2dd071 to 05e2ea7 Sep 3, 2019
@alxhub
alxhub approved these changes Sep 4, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Prior to this commit, complex expressions (that require additional statements to be generated) were handled incorrectly in case they were used in attributes annotated with i18n flags. The problem was caused by the fact that extra statements were not appended to the temporary vars block, so they were missing in generated code. This commit updated the logic to use the `convertPropertyBinding`, which contains the necessary code to append extra statements. The `convertExpressionBinding` function was removed as it duplicates the `convertPropertyBinding` one (for the most part) and is no longer used.
@AndrewKushnir AndrewKushnir force-pushed the AndrewKushnir:i18n_complex_expr_in_attrs branch from 05e2ea7 to 8f3aa88 Sep 5, 2019
@matsko matsko closed this in f00d033 Sep 5, 2019
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
Prior to this commit, complex expressions (that require additional statements to be generated) were handled incorrectly in case they were used in attributes annotated with i18n flags. The problem was caused by the fact that extra statements were not appended to the temporary vars block, so they were missing in generated code. This commit updated the logic to use the `convertPropertyBinding`, which contains the necessary code to append extra statements. The `convertExpressionBinding` function was removed as it duplicates the `convertPropertyBinding` one (for the most part) and is no longer used.

PR Close angular#32309
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
Prior to this commit, complex expressions (that require additional statements to be generated) were handled incorrectly in case they were used in attributes annotated with i18n flags. The problem was caused by the fact that extra statements were not appended to the temporary vars block, so they were missing in generated code. This commit updated the logic to use the `convertPropertyBinding`, which contains the necessary code to append extra statements. The `convertExpressionBinding` function was removed as it duplicates the `convertPropertyBinding` one (for the most part) and is no longer used.

PR Close angular#32309
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.