Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): debug node names should match user declaration #32328

Closed
wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

commented Aug 26, 2019

Querying for elements by name generally fails in Ivy because users most frequently search for names by lower case whereas Ivy currently returns the node names as uppercase (the test added to the spec fails both cases in Ivy but passes in VE). The current behavior of VE is to return the name as it was declared in the template. This PR matches that behavior in Ivy.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently node names in Ivy return all caps from the nativeNode.nodeName

Issue Number: N/A

What is the new behavior?

Debug Element node names will match the TNode tagName.

Does this PR introduce a breaking change?

  • Yes
  • No

@atscott atscott requested a review from angular/fw-core as a code owner Aug 26, 2019

@googlebot googlebot added the cla: yes label Aug 26, 2019

@ngbot ngbot bot added this to the needsTriage milestone Aug 27, 2019

@kara
kara approved these changes Aug 27, 2019
Copy link
Contributor

left a comment

LGTM

@kara kara removed the PR action: review label Aug 27, 2019

@atscott

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@atscott atscott closed this in 14feb56 Aug 27, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.