Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): remove repeated memory read / write in addComponentLogic #32339

Conversation

@pkozlowski-opensource
Copy link
Member

commented Aug 27, 2019

addComponentLogic was showing quite high on the expanding rows benchmarks profile and it turned out that it does unnecessary memory read / writes:

  • native host node was read twice ( getNativeByTNode(hostTNode, lView) and lView[hostTNode.index]);
  • componentView[T_HOST] was set twice (once in createLView and second time explicitly).

@googlebot googlebot added the cla: yes label Aug 27, 2019

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Aug 27, 2019

@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Aug 27, 2019

@ngbot ngbot bot modified the milestone: needsTriage Aug 27, 2019

@mhevery

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.