Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element and text create perf #32342

Conversation

@pkozlowski-opensource
Copy link
Member

commented Aug 27, 2019

This PR adds a new benchmark focused on the creation time of a view (and more specifically on the ɵɵelementStart, ɵɵelementEnd and ɵɵtext instructions. The goal here is to exercise performance of elements / text nodes creation perf after firstTemplatePass.

As a "bonus" this PR also has 2 tiny cleanups spotted when running the new benchmark for the first time.

Hint: review commit-by-commit.

@googlebot googlebot added the cla: yes label Aug 27, 2019

perf(ivy): remove renderStringify calls for text nodes creation
Values passed to the `ɵɵtext` instruction are strings (or undefined)
in the generated code so no need to stringify those again.

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:elemnt_and_text_create_perf branch from 37b83fd to 1ae0a05 Aug 27, 2019

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Aug 27, 2019

@pkozlowski-opensource pkozlowski-opensource requested review from angular/fw-core as code owners Aug 27, 2019

@ngbot ngbot bot added this to the needsTriage milestone Aug 27, 2019


// profile create views (run templates in creation mode)
console.profile('create');
for (let i = 0; i < 500000; i++) {

This comment has been minimized.

Copy link
@mhevery

mhevery Aug 27, 2019

Member

can we start using this perf harness?

@mhevery

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@kara
kara approved these changes Aug 27, 2019
Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

merge-assistance: global approval

@mhevery mhevery closed this in 85864ed Aug 29, 2019

mhevery added a commit that referenced this pull request Aug 29, 2019
perf(ivy): remove renderStringify calls for text nodes creation (#32342)
Values passed to the `ɵɵtext` instruction are strings (or undefined)
in the generated code so no need to stringify those again.

PR Close #32342
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
perf(ivy): remove renderStringify calls for text nodes creation (angu…
…lar#32342)

Values passed to the `ɵɵtext` instruction are strings (or undefined)
in the generated code so no need to stringify those again.

PR Close angular#32342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.