Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Use ts.CompletionEntry for completions #32375

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

commented Aug 28, 2019

This is a prerequisite to fix a bug in template completions whereby
completion of the string ti for the variable title results in
tititle.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
replacementSpan should be used to indicate the span of text that needs
to be replaced. Angular's own Completion interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for CompletionKind, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz Aug 28, 2019

@kyliau kyliau requested a review from angular/tools-language-service as a code owner Aug 28, 2019

@googlebot googlebot added the cla: yes label Aug 28, 2019

packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/types.ts Outdated Show resolved Hide resolved

@ngbot ngbot bot added this to the needsTriage milestone Aug 28, 2019

@kyliau kyliau force-pushed the kyliau:completions branch from 2b6b00d to 5b63822 Aug 28, 2019

@kyliau kyliau requested a review from angular/fw-integration as a code owner Aug 28, 2019

@kyliau
Copy link
Member Author

left a comment

For Enum, the declaration itself should be CamelCase whereas the enum values should be CONSTANT_CASE.

packages/language-service/src/utils.ts Outdated Show resolved Hide resolved
fix(language-service): Use ts.CompletionEntry for completions
This is a prerequisite to fix a bug in template completions whereby
completion of the string `ti` for the variable `title` results in
`tititle`.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
`replacementSpan` should be used to indicate the span of text that needs
to be replaced. Angular's own `Completion` interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for `CompletionKind`, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.

@kyliau kyliau force-pushed the kyliau:completions branch from 5b63822 to c8efde8 Sep 3, 2019

@mhevery mhevery closed this in f6e88cd Sep 4, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(language-service): Use ts.CompletionEntry for completions (angula…
…r#32375)

This is a prerequisite to fix a bug in template completions whereby
completion of the string `ti` for the variable `title` results in
`tititle`.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
`replacementSpan` should be used to indicate the span of text that needs
to be replaced. Angular's own `Completion` interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for `CompletionKind`, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.

PR Close angular#32375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.