Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Create DirectiveKind enum #32376

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

commented Aug 28, 2019

Hovering over a selector, the QuickInfo display string is something
like:

(component) AppComponent

where component is the symbol kind.
Prior to this, there was no types to indicate the possible values of a
symbol. This PR creates an enum to represent that.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz Aug 28, 2019

@kyliau kyliau requested a review from angular/tools-language-service as a code owner Aug 28, 2019

@ngbot ngbot bot added this to the needsTriage milestone Aug 28, 2019

@googlebot googlebot added the cla: yes label Aug 28, 2019

packages/language-service/src/types.ts Outdated Show resolved Hide resolved
packages/language-service/src/types.ts Outdated Show resolved Hide resolved

@kyliau kyliau force-pushed the kyliau:locate_symbol branch from 2a7de9e to 44cb97f Aug 28, 2019

fix(language-service): Create DirectiveKind enum
Hovering over a selector, the QuickInfo display string is something
like:
```
(component) AppComponent
```
where `component` is the symbol kind.
Prior to this, there was no types to indicate the possible values of a
symbol. This PR creates an enum to represent that.

@kyliau kyliau force-pushed the kyliau:locate_symbol branch from 44cb97f to cae21fa Aug 28, 2019

@mhevery mhevery closed this in 852afb3 Aug 29, 2019

@kyliau kyliau deleted the kyliau:locate_symbol branch Aug 29, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(language-service): Create DirectiveKind enum (angular#32376)
Hovering over a selector, the QuickInfo display string is something
like:
```
(component) AppComponent
```
where `component` is the symbol kind.
Prior to this, there was no types to indicate the possible values of a
symbol. This PR creates an enum to represent that.

PR Close angular#32376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.