Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-service): cleanup tests for Hover #32378

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

commented Aug 28, 2019

Move generic test methods to MockTypescriptHost so they could be
shared across all tests.

This is in preparation for adding more tests to Hover when new features
get added.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

refactor(language-service): cleanup tests for Hover
Move generic test methods to `MockTypescriptHost` so they could be
shared across all tests.

This is in preparation for adding more tests to Hover when new features
get added.

@kyliau kyliau requested a review from ayazhafiz Aug 28, 2019

@kyliau kyliau requested a review from angular/tools-language-service as a code owner Aug 28, 2019

@ngbot ngbot bot modified the milestone: needsTriage Aug 28, 2019

@googlebot googlebot added the cla: yes label Aug 28, 2019

@mhevery mhevery closed this in 18ce58c Aug 29, 2019

@kyliau kyliau deleted the kyliau:hover branch Aug 29, 2019

ayazhafiz added a commit to ayazhafiz/angular that referenced this pull request Sep 1, 2019
fix(language-service): re-add regressed templateUrl tests
Commit 18ce58 (per angular#32378) regressed tests for templateUrl definitions.
This PR re-adds those tests.
@ayazhafiz ayazhafiz referenced this pull request Sep 1, 2019
5 of 14 tasks complete
mhevery added a commit that referenced this pull request Sep 3, 2019
fix(language-service): re-add regressed templateUrl tests (#32438)
Commit 18ce58 (per #32378) regressed tests for templateUrl definitions.
This PR re-adds those tests.

PR Close #32438
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
refactor(language-service): cleanup tests for Hover (angular#32378)
Move generic test methods to `MockTypescriptHost` so they could be
shared across all tests.

This is in preparation for adding more tests to Hover when new features
get added.

PR Close angular#32378
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(language-service): re-add regressed templateUrl tests (angular#32438
)

Commit 18ce58 (per angular#32378) regressed tests for templateUrl definitions.
This PR re-adds those tests.

PR Close angular#32438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.