Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): ngcc - improve the "ngcc version changed" error message #32396

Closed

Conversation

@petebacondarwin
Copy link
Member

commented Aug 29, 2019

If a project has nested projects that contain node_modules folders
that get processed by ngcc, it can be confusing when the ngcc
version changes since the error message is very generic:

The ngcc compiler has changed since the last ngcc build.
Please completely remove `node_modules` and try again.

This commit augments the error message with the path of
the entry-point that failed so that it is more obvious which
node_modules folder to remove:

The ngcc compiler has changed since the last ngcc build.
Please completely remove the "node_modules" folder containing "/my/app/node_modules/entry-point" and try again.

BREAKING CHANGE:

This commit removes the public export of hasBeenProcessed().

This was exported to be availble to the CLI integration but was never
used. The change to the function signature is a breaking change in itself
so we remove the function altogether to simplify and lower the public
API surface going forward.

fix(ivy): ngcc - improve the "ngcc version changed" error message
If a project has nested projects that contain node_modules folders
that get processed by ngcc, it can be confusing when the ngcc
version changes since the error message is very generic:

```
The ngcc compiler has changed since the last ngcc build.
Please completely remove `node_modules` and try again.
```

This commit augments the error message with the path of
the entry-point that failed so that it is more obvious which
node_modules folder to remove.

BREAKING CHANGE:

This commit removes the public export of `hasBeenProcessed()`.

This was exported to be availble to the CLI integration but was never
used. The change to the function signature is a breaking change in itself
so we remove the function altogether to simplify and lower the public
API surface going forward.

@mhevery mhevery closed this in d5101df Aug 29, 2019

@gkalpak
Copy link
Member

left a comment

LGTM

@petebacondarwin

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

Phew!

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(ivy): ngcc - improve the "ngcc version changed" error message (an…
…gular#32396)

If a project has nested projects that contain node_modules folders
that get processed by ngcc, it can be confusing when the ngcc
version changes since the error message is very generic:

```
The ngcc compiler has changed since the last ngcc build.
Please completely remove `node_modules` and try again.
```

This commit augments the error message with the path of
the entry-point that failed so that it is more obvious which
node_modules folder to remove.

BREAKING CHANGE:

This commit removes the public export of `hasBeenProcessed()`.

This was exported to be availble to the CLI integration but was never
used. The change to the function signature is a breaking change in itself
so we remove the function altogether to simplify and lower the public
API surface going forward.

PR Close angular#32396

@petebacondarwin petebacondarwin deleted the petebacondarwin:ngcc-error-fix branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.