Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): properly initialise global state in the element_text_create benchmark #32397

Conversation

@pkozlowski-opensource
Copy link
Member

commented Aug 29, 2019

Without the resetComponentState() the elementDepthCount global state was undefined so trying to increment / decrement it was causing type coercion which was showing up under a profiler

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:create_benchmark_analysis branch from 1fae935 to e6d337f Aug 30, 2019

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Aug 30, 2019

@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Aug 30, 2019

@mhevery mhevery closed this in 8dc3f36 Aug 30, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.