Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): add a micro benchmark for style and class bindings #32401

Closed
wants to merge 2 commits into from

Conversation

@matsko
Copy link
Member

commented Aug 29, 2019

This patch introduces a new micro benchmark that performance tests
against style and class bindings in Ivy running together on the same
element.

@googlebot googlebot added the cla: yes label Aug 29, 2019

@matsko

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

[style_and_class_bindings]
IVY MASTER = 31.01s user 0.25s system 102% cpu 30.593 total
IVY STYLING PROTOTYPE = 21.91s user 0.11s system 100% cpu 21.981 total

[map_based_style_and_class_bindings]
IVY MASTER = 74.71s user 1.29s system 104% cpu 1:12.94 total
IVY STYLING PROTOTYPE = 71.77s user 1.11s system 102% cpu 1:10.98 total
@kara
kara approved these changes Aug 29, 2019
Copy link
Contributor

left a comment

LGTM (looks like lint is unhappy though)

@ngbot ngbot bot added this to the needsTriage milestone Aug 29, 2019

@kara kara marked this pull request as ready for review Aug 29, 2019

@kara kara requested a review from angular/fw-core as a code owner Aug 29, 2019

@kara kara assigned kara and matsko and unassigned kara Aug 29, 2019

matsko added 2 commits Aug 29, 2019
perf(ivy): add a micro benchmark for style and class bindings
This patch introduces a new micro benchmark that performance tests
against style and class bindings in Ivy running together on the same
element.
perf(ivy): add a micro benchmark for map-based style and class bindings
This patch introduces a new micro benchmark that performance tests
against map-based style and class bindings in Ivy running together
on the same element.
@kara
kara approved these changes Aug 29, 2019

@matsko matsko closed this in df8e675 Aug 30, 2019

matsko added a commit that referenced this pull request Aug 30, 2019
perf(ivy): add a micro benchmark for map-based style and class bindin…
…gs (#32401)

This patch introduces a new micro benchmark that performance tests
against map-based style and class bindings in Ivy running together
on the same element.

PR Close #32401
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
perf(ivy): add a micro benchmark for style and class bindings (angula…
…r#32401)

This patch introduces a new micro benchmark that performance tests
against style and class bindings in Ivy running together on the same
element.

PR Close angular#32401
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
perf(ivy): add a micro benchmark for map-based style and class bindin…
…gs (angular#32401)

This patch introduces a new micro benchmark that performance tests
against map-based style and class bindings in Ivy running together
on the same element.

PR Close angular#32401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.