Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): Mark TestBed.get as deprecated #32406

Closed
wants to merge 1 commit into from

Conversation

@Goodwine
Copy link
Contributor

commented Aug 29, 2019

We should now use TestBed.inject
See #32200

Fixes #26491

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Marked TestBed.get as @deprecated

What is the current behavior?

TestBed.get is usable

Issue Number: #26491

What is the new behavior?

TestBed.get is usable BUT deprecated.
We should now use TestBed.inject from Angular 9.0.0+

Does this PR introduce a breaking change?

  • Yes
  • No

Not a breaking change but it will affect linters until users migrate, it should be a warning, not a failure.

Other information

@Goodwine Goodwine requested review from angular/fw-core as code owners Aug 29, 2019
@googlebot googlebot added the cla: yes label Aug 29, 2019
@mhevery mhevery self-assigned this Sep 3, 2019
@mhevery mhevery added the comp: core label Sep 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 3, 2019
@vikerman

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

I would actually call this out as feat(core): TestBed.get is now deprecated in the commit message. And mention the alternative in the commit message

@Goodwine Goodwine force-pushed the Goodwine:deprecate-testbed.get branch from b044e2f to ddd0cb5 Sep 6, 2019
@Goodwine

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

I would actually call this out as feat(core): TestBed.get is now deprecated in the commit message.

Done

And mention the alternative in the commit message

It was already mentioned, but reworded now

@ngbot

This comment has been minimized.

Copy link

commented Sep 9, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_docs_examples_ivy" is failing
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

From 9.0.0 use TestBed.inject
See #32200

Fixes #26491
@Goodwine Goodwine force-pushed the Goodwine:deprecate-testbed.get branch from ddd0cb5 to 14c996e Sep 9, 2019
@Goodwine

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

IDK why the test was failing, it didn't seem to be related to my change, but it looks like it's now passing after I sync'd

@matsko

This comment has been minimized.

@mhevery

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

GLOBAL APPROVAL

@matsko matsko closed this in a85eccd Sep 12, 2019
@Goodwine Goodwine deleted the Goodwine:deprecate-testbed.get branch Sep 12, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.