Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): re-add regressed templateUrl tests #32438

Closed

Conversation

@ayazhafiz
Copy link
Contributor

commented Sep 1, 2019

Commit 18ce58c (per #32378) regressed tests for templateUrl definitions.
This PR re-adds those tests.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(language-service): re-add regressed templateUrl tests
Commit 18ce58 (per #32378) regressed tests for templateUrl definitions.
This PR re-adds those tests.

@ayazhafiz ayazhafiz requested a review from kyliau Sep 1, 2019

@ayazhafiz ayazhafiz requested a review from angular/tools-language-service as a code owner Sep 1, 2019

@ayazhafiz ayazhafiz self-assigned this Sep 1, 2019

@ngbot ngbot bot added this to the needsTriage milestone Sep 1, 2019

@googlebot googlebot added the cla: yes label Sep 1, 2019

@kyliau
kyliau approved these changes Sep 3, 2019
Copy link
Member

left a comment

oops, sorry about that!

@mhevery mhevery closed this in 1ed3531 Sep 3, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
fix(language-service): re-add regressed templateUrl tests (angular#32438
)

Commit 18ce58 (per angular#32378) regressed tests for templateUrl definitions.
This PR re-adds those tests.

PR Close angular#32438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.