Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): guard directive-related operations with a TNode flag #32445

Conversation

@pkozlowski-opensource
Copy link
Member

commented Sep 2, 2019

There are multiple places where we call directive-related functions on a node. In real-life applications many nodes won't be a host for any directive, so often times those calls are wasteful. This PR introduces a new flag for TNode (isDirectiveHost ) and ensures that any directive-related logic execution is guarded by this new flag.

@googlebot googlebot added the cla: yes label Sep 2, 2019

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:tnode_flags branch from cd1213e to 1c840b8 Sep 2, 2019

@ngbot ngbot bot modified the milestone: needsTriage Sep 2, 2019

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Sep 2, 2019

@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Sep 2, 2019

@kara
kara approved these changes Sep 2, 2019
Copy link
Contributor

left a comment

LGTM

packages/core/src/render3/instructions/lview_debug.ts Outdated Show resolved Hide resolved

@kara kara assigned kara and pkozlowski-opensource and unassigned kara Sep 2, 2019

@kara

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@mhevery mhevery closed this in 641c5c1 Sep 4, 2019

sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.