Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): warn instead of throwing for unknown properties #32463

Closed

Conversation

@crisbeto
Copy link
Member

commented Sep 3, 2019

Logs a warning instead of throwing when running into a binding to an unknown property in JIT mode. Since we aren't using a schema for the runtime validation anymore, this allows us to support browsers where properties are unsupported.

@googlebot googlebot added the cla: yes label Sep 3, 2019
@crisbeto crisbeto marked this pull request as ready for review Sep 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 3, 2019
@crisbeto crisbeto requested review from angular/fw-core as code owners Sep 3, 2019
packages/core/src/render3/instructions/shared.ts Outdated Show resolved Hide resolved
@crisbeto crisbeto force-pushed the crisbeto:FW-1517/unknown-prop-warning branch from a72a459 to 8ad2099 Sep 4, 2019
Logs a warning instead of throwing when running into a binding to an unknown property in JIT mode. Since we aren't using a schema for the runtime validation anymore, this allows us to support browsers where properties are unsupported.
@crisbeto crisbeto force-pushed the crisbeto:FW-1517/unknown-prop-warning branch from 8ad2099 to 8c11075 Sep 4, 2019
@crisbeto crisbeto removed their assignment Sep 4, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

The feedback has been addressed @kara.

@kara
kara approved these changes Sep 5, 2019
Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

@matsko matsko closed this in bc061b7 Sep 6, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
)

Logs a warning instead of throwing when running into a binding to an unknown property in JIT mode. Since we aren't using a schema for the runtime validation anymore, this allows us to support browsers where properties are unsupported.

PR Close angular#32463
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.