Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve the "missing `$localize`" error message #32491

Conversation

@petebacondarwin
Copy link
Member

commented Sep 5, 2019

We need to be clearer to developers who upgrade to v9 (next) and get this
error, why they have a problem and what they have to do about it.

Once we have a better CLI schematics story, where this import will be
included by default in new applications and a CLI migration will add it
when upgrading apps to v9, we could simplify or remove this error message.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@petebacondarwin petebacondarwin requested a review from angular/fw-core as a code owner Sep 5, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 5, 2019
@googlebot googlebot added the cla: yes label Sep 5, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-global-import-message branch from 0931640 to 8d1d35e Sep 5, 2019
@petebacondarwin petebacondarwin requested a review from angular/fw-integration as a code owner Sep 5, 2019
We need to be clearer to developers who upgrade to v9 (next) and get this
error, why they have a problem and what they have to do about it.

Once we have a better CLI schematics story, where this import will be
included by default in new applications and a CLI migration will add it
when upgrading apps to v9, we could simplify or remove this error message.
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-global-import-message branch from 8d1d35e to 731ff3f Sep 5, 2019
@mhevery
mhevery approved these changes Sep 5, 2019
@kara
kara approved these changes Sep 5, 2019
Copy link
Contributor

left a comment

LGTM

@matsko matsko closed this in a9ff48e Sep 5, 2019
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
…2491)

We need to be clearer to developers who upgrade to v9 (next) and get this
error, why they have a problem and what they have to do about it.

Once we have a better CLI schematics story, where this import will be
included by default in new applications and a CLI migration will add it
when upgrading apps to v9, we could simplify or remove this error message.

PR Close angular#32491
@petebacondarwin petebacondarwin deleted the petebacondarwin:i18n-global-import-message branch Sep 10, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…2491)

We need to be clearer to developers who upgrade to v9 (next) and get this
error, why they have a problem and what they have to do about it.

Once we have a better CLI schematics story, where this import will be
included by default in new applications and a CLI migration will add it
when upgrading apps to v9, we could simplify or remove this error message.

PR Close angular#32491
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.