Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listeners perf #32495

Conversation

@pkozlowski-opensource
Copy link
Member

commented Sep 5, 2019

This PR introduces a new benchmark focused on listeners creation. It also contains small refactoring and performance improvement. Go over this PR commit-by-commit for easier review

@googlebot googlebot added the cla: yes label Sep 5, 2019

// profile create views (run templates in creation mode)
console.profile('create listeners');
for (let i = 0; i < 500000; i++) {

This comment has been minimized.

Copy link
@mhevery

This comment has been minimized.

Copy link
@pkozlowski-opensource

pkozlowski-opensource Sep 10, 2019

Author Member

Done, it is using the micro-harness right now.

@mhevery mhevery added the comp: core label Sep 5, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 5, 2019
@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:listeners_perf branch from 1c9e0a1 to 092f866 Sep 10, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Sep 10, 2019
@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Sep 10, 2019
@kara
kara approved these changes Sep 10, 2019
Copy link
Contributor

left a comment

LGTM, one nit

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:listeners_perf branch from 092f866 to 3f21f13 Sep 12, 2019
Before this refactoring we had 2 utility functions to check if a given
TNode has matching directives. This PR leaves just one such function
(one that does less memory read).
@kara kara closed this in 024765b Sep 12, 2019
kara added a commit that referenced this pull request Sep 12, 2019
Before this refactoring we had 2 utility functions to check if a given
TNode has matching directives. This PR leaves just one such function
(one that does less memory read).

PR Close #32495
kara added a commit that referenced this pull request Sep 12, 2019
kara added a commit that referenced this pull request Sep 12, 2019
kara added a commit that referenced this pull request Sep 12, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
Before this refactoring we had 2 utility functions to check if a given
TNode has matching directives. This PR leaves just one such function
(one that does less memory read).

PR Close angular#32495
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.