Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): template compiler should render correct $localize placeholder names #32509

Conversation

@petebacondarwin
Copy link
Member

commented Sep 6, 2019

The goog.getMsg() function requires placeholder names to be camelCased.

This is not the case for $localize. Here placeholder names need
match what is serialized to translation files.

Specifically such placeholder names keep their casing but have all characters
that are not in a-z, A-Z, 0-9 and _ converted to _.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@petebacondarwin petebacondarwin requested a review from AndrewKushnir Sep 6, 2019
@petebacondarwin petebacondarwin requested review from angular/fw-compiler as code owners Sep 6, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 6, 2019
@googlebot googlebot added the cla: yes label Sep 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 6, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-localize-placeholders branch 3 times, most recently from d5a3043 to edb0dcb Sep 6, 2019
@petebacondarwin petebacondarwin requested a review from angular/fw-core as a code owner Sep 6, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-localize-placeholders branch from edb0dcb to f81282c Sep 6, 2019
@mhevery
mhevery approved these changes Sep 6, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-localize-placeholders branch from f81282c to 40fefb0 Sep 6, 2019
Copy link
Contributor

left a comment

LGTM 👍 Thanks Pete!

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Merge assistance: ci/angular: size is a pre-existing issue affecting other PRs as well.

…er names

The `goog.getMsg()` function requires placeholder names to be camelCased.

This is not the case for `$localize`. Here placeholder names need
match what is serialized to translation files.

Specifically such placeholder names keep their casing but have all characters
that are not in `a-z`, `A-Z`, `0-9` and `_` converted to `_`.
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-localize-placeholders branch from 40fefb0 to 9f9064f Sep 7, 2019
@matsko matsko closed this in ea6a2e9 Sep 9, 2019
@petebacondarwin petebacondarwin deleted the petebacondarwin:i18n-localize-placeholders branch Sep 10, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…er names (angular#32509)

The `goog.getMsg()` function requires placeholder names to be camelCased.

This is not the case for `$localize`. Here placeholder names need
match what is serialized to translation files.

Specifically such placeholder names keep their casing but have all characters
that are not in `a-z`, `A-Z`, `0-9` and `_` converted to `_`.

PR Close angular#32509
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.