Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): unable to override ComponentFactoryResolver provider in tests #32512

Closed
wants to merge 2 commits into from

Conversation

@atscott
Copy link
Contributor

commented Sep 6, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Cannot override ComponentFactoryResolver in TestBed tests. The test added in this PR was failing in Ivy without the change in r3_injector

@atscott atscott requested a review from AndrewKushnir Sep 6, 2019
@atscott atscott requested a review from angular/fw-core as a code owner Sep 6, 2019
@googlebot googlebot added the cla: yes label Sep 6, 2019
@AndrewKushnir AndrewKushnir requested a review from kara Sep 6, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Thanks for making additional changes @atscott, the changes LGTM 👍

@kara could you please have a look at these changes as well?

Thank you.

@kara
kara approved these changes Sep 10, 2019
Copy link
Contributor

left a comment

LGTM

@ngbot

This comment has been minimized.

Copy link

commented Sep 10, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"
    failure status "ci/angular: size" is failing
    pending missing required labels: PR target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott force-pushed the atscott:cfr branch from b8356b1 to a20eec4 Sep 10, 2019
@matsko matsko added the comp: ivy label Sep 10, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 10, 2019
@matsko

This comment has been minimized.

@matsko matsko closed this in 2124588 Sep 10, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.