Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): add script to rebuild, refresh Angular dist #32515

Closed
wants to merge 1 commit into from

Conversation

@ayazhafiz
Copy link
Contributor

commented Sep 6, 2019

The Language Service integration tests should reinstall the Angular
distribution every time it is built. Adds a yarn build-dist
convinience script so building the distribution doesn't have to
happen on the repo root. This new script also refreshes the installed
modules. Building is expensive, so it is not bundled with testing
scripts.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The Language Service integration tests should reinstall the Angular
distribution every time it is built. Adds a `yarn build-dist`
convinience script so building the distribution doesn't have to
happen on the repo root. This new script also refreshes the installed
modules. Building is expesnive, so it is not bundled with testing
scripts.
@ayazhafiz ayazhafiz requested a review from kyliau Sep 6, 2019
@ayazhafiz ayazhafiz requested a review from angular/fw-integration as a code owner Sep 6, 2019
@ayazhafiz ayazhafiz self-assigned this Sep 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 6, 2019
@googlebot googlebot added the cla: yes label Sep 6, 2019
@ayazhafiz ayazhafiz requested a review from josephperrott Sep 6, 2019
Copy link
Member

left a comment

LGTM

@kyliau
kyliau approved these changes Sep 6, 2019
@@ -12,6 +12,7 @@
},
"scripts": {
"build": "tsc -p tsconfig.json",
"build-dist": "../../scripts/build-packages-dist.sh && yarn install --check-files",

This comment has been minimized.

Copy link
@kyliau

kyliau Sep 6, 2019

Member

Just curious, does --check-files only check for consistency and not actually install the dependencies?
It's not apparent from the help page: --check-files install will verify file tree of packages for consistency

This comment has been minimized.

Copy link
@ayazhafiz

ayazhafiz Sep 6, 2019

Author Contributor

It will install packages whose file trees are outdated.

@matsko matsko closed this in 1716b91 Sep 6, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…ngular#32515)

The Language Service integration tests should reinstall the Angular
distribution every time it is built. Adds a `yarn build-dist`
convinience script so building the distribution doesn't have to
happen on the repo root. This new script also refreshes the installed
modules. Building is expesnive, so it is not bundled with testing
scripts.

PR Close angular#32515
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.