Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): replace select instruction with advance #32516

Closed
wants to merge 2 commits into from

Conversation

@crisbeto
Copy link
Member

commented Sep 6, 2019

Replaces the select instruction with a new one called advance. Instead of the jumping to a specific index, the new instruction goes forward X amount of elements. The advantage of doing this is that it should generate code that compresses better.

@googlebot googlebot added the cla: yes label Sep 6, 2019
@crisbeto crisbeto force-pushed the crisbeto:FW-1544/advance-instruction branch from 4542934 to 123c683 Sep 6, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 6, 2019
@crisbeto crisbeto marked this pull request as ready for review Sep 6, 2019
@crisbeto crisbeto requested review from IgorMinar and angular/fw-compiler as code owners Sep 6, 2019
@crisbeto crisbeto force-pushed the crisbeto:FW-1544/advance-instruction branch from 123c683 to 464c062 Sep 6, 2019
Replaces the `select` instruction with a new one called `advance`. Instead of the jumping to a specific index, the new instruction goes forward X amount of elements. The advantage of doing this is that it should generate code the compresses better.
@crisbeto crisbeto force-pushed the crisbeto:FW-1544/advance-instruction branch from 464c062 to af7b610 Sep 6, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

Updated to remove the advance instruction for i18n @kara. Also added an extra error during compilation so we don't generate negative advance instructions.

@crisbeto crisbeto removed their assignment Sep 7, 2019
@kara
kara approved these changes Sep 8, 2019
Copy link
Contributor

left a comment

LGTM

@kara kara removed the PR action: review label Sep 8, 2019
Copy link
Member

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

@kara

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

merge-assistance: global approval

@matsko matsko closed this in 664e001 Sep 10, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
Replaces the `select` instruction with a new one called `advance`. Instead of the jumping to a specific index, the new instruction goes forward X amount of elements. The advantage of doing this is that it should generate code the compresses better.

PR Close angular#32516
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.