Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): run tree benchmark with bundles and ngDevMode off #32558

Conversation

@pkozlowski-opensource
Copy link
Member

commented Sep 9, 2019

Before this change the tree benchmark was running with the un-bundled version, without ngDevMode tree-shaken away. This was very slow setup for ngIvy as we were essentially running in the dev mode.

@kara
kara approved these changes Sep 9, 2019
Copy link
Contributor

left a comment

LGTM

@kara kara removed the PR action: review label Sep 9, 2019
@kara kara marked this pull request as ready for review Sep 9, 2019
@kara kara requested a review from IgorMinar as a code owner Sep 9, 2019
@kara

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

merge-assistance: global approval

@mhevery
mhevery approved these changes Sep 9, 2019
@matsko matsko closed this in c3a1ef2 Sep 9, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.