Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(language-service): keep analyzedModules cache when source files don't change #32562

Closed
wants to merge 1 commit into from

Conversation

@andrius-pra
Copy link
Contributor

commented Sep 9, 2019

This change will improve performance of language service when working in external templates.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@andrius-pra andrius-pra requested a review from angular/tools-language-service as a code owner Sep 9, 2019
@googlebot googlebot added the cla: yes label Sep 9, 2019
@andrius-pra andrius-pra force-pushed the andrius-pra:perf branch from c7b9fe0 to fcff4b2 Sep 10, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 10, 2019
@ayazhafiz

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

LGTM!

@kyliau
kyliau approved these changes Sep 10, 2019
packages/language-service/src/typescript_host.ts Outdated Show resolved Hide resolved
…don't change

This change will improve performance of language service when working in external templates.
@andrius-pra andrius-pra force-pushed the andrius-pra:perf branch from fcff4b2 to a6b28f4 Sep 10, 2019
@matsko matsko closed this in 4f03323 Sep 11, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…don't change (angular#32562)

This change will improve performance of language service when working in external templates.

PR Close angular#32562
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.