Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): DebugNode throws exceptions when querying some properties #32622

Closed
wants to merge 4 commits into from

Conversation

@atscott
Copy link
Contributor

commented Sep 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

In Ivy, DebugElement.query throws exceptions when querying some properties because it encounters elements created outside Angular's context.

Issue Number: N/A

What is the new behavior?

No exceptions are thrown

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

DebugElement.injector still throws an exception because the interface doesn't support returning null.

@atscott atscott requested a review from angular/fw-core as a code owner Sep 11, 2019
@googlebot googlebot added the cla: yes label Sep 11, 2019
@atscott atscott requested a review from AndrewKushnir Sep 11, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 11, 2019
@atscott atscott force-pushed the atscott:debugNode branch from 69b3358 to c57179c Sep 11, 2019
@atscott atscott force-pushed the atscott:debugNode branch from c57179c to f2535cb Sep 11, 2019
@atscott atscott force-pushed the atscott:debugNode branch from 844916a to 93cf179 Sep 11, 2019
@atscott atscott requested a review from kara Sep 11, 2019
@atscott atscott force-pushed the atscott:debugNode branch from 93cf179 to 975c911 Sep 12, 2019
packages/core/src/debug/debug_node.ts Outdated Show resolved Hide resolved
@atscott atscott force-pushed the atscott:debugNode branch 2 times, most recently from 6c23183 to e41ec24 Sep 12, 2019
@atscott atscott force-pushed the atscott:debugNode branch from e41ec24 to 0ff7615 Sep 12, 2019
@atscott

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@kara
kara approved these changes Sep 12, 2019
Copy link
Contributor

left a comment

LGTM

@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.