Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): avoid repeat lview reads in pipe instructions #32633

Closed
wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

commented Sep 12, 2019

All of the pipeBind instructions call into isPure and unwrapValue which in turn call getLView internally. These internal calls are redundant, because we already have the LView from the load calls just before it.

All of the `pipeBind` instructions call into `isPure` and `unwrapValue` which in turn call `getLView` internally. These internal calls are redundant, because we already have the `LView` from the `load` calls just before it.
@googlebot googlebot added the cla: yes label Sep 12, 2019
@matsko matsko added the comp: ivy label Sep 12, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 12, 2019
@crisbeto crisbeto marked this pull request as ready for review Sep 12, 2019
@crisbeto crisbeto requested a review from angular/fw-core as a code owner Sep 12, 2019
Copy link
Member

left a comment

LGTM

Copy link
Member

left a comment

LGTM, thnx for doing this!

@mhevery

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@kara kara closed this in 73cb581 Sep 12, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
All of the `pipeBind` instructions call into `isPure` and `unwrapValue` which in turn call `getLView` internally. These internal calls are redundant, because we already have the `LView` from the `load` calls just before it.

PR Close angular#32633
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Oct 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.